Allow Polaris to be built against a locally built Quarkus snapshot#4009
Open
snazy wants to merge 1 commit intoapache:mainfrom
Open
Allow Polaris to be built against a locally built Quarkus snapshot#4009snazy wants to merge 1 commit intoapache:mainfrom
snazy wants to merge 1 commit intoapache:mainfrom
Conversation
This change allows Polaris to use Quarkus artifacts from the local Maven repository, think: `~/.m2/repository`, for the build. The implementation is completely transparent to the "non Quarkus snapshot" build, as all necessary tweaks are applied via a Gradle init script that needs to be manually configured during the Gradle invocation. In other words: no harm to the "normal" build. As we collaborate with the Quarkus project, it is a win-win to have some support to build Polaris against a custom Quarkus build. This allows both "Polaris people" and "Quarkus people" to test changes and fixes before a release and/or to investigate issues. On top, there's another Gradle init script to build Polaris against a Quarkus pre-release, for example, 4.0.0.CR1. Those releases to not publish a platform bom, so some special handling is needed. It seemed convenient to move the existing special handling for Apache Snapshots to a separate init script as well, removing some clutter from the main settings.gradle.kts file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows Polaris to use Quarkus artifacts from the local Maven repository, think:
~/.m2/repository, for the build.The implementation is completely transparent to the "non Quarkus snapshot" build, as all necessary tweaks are applied via a Gradle init script that needs to be manually configured during the Gradle invocation. In other words: no harm to the "normal" build.
As we collaborate with the Quarkus project, it is a win-win to have some support to build Polaris against a custom Quarkus build. This allows both "Polaris people" and "Quarkus people" to test changes and fixes before a release and/or to investigate issues.
On top, there's another Gradle init script to build Polaris against a Quarkus pre-release, for example, 4.0.0.CR1. Those releases to not publish a platform bom, so some special handling is needed.
It seemed convenient to move the existing special handling for Apache Snapshots to a separate init script as well, removing some clutter from the main settings.gradle.kts file.