fix(verify-release): fix bash pipe FD leak causing deadlock on maven checksum verification#4024
Open
adnanhemani wants to merge 2 commits intomainfrom
Open
fix(verify-release): fix bash pipe FD leak causing deadlock on maven checksum verification#4024adnanhemani wants to merge 2 commits intomainfrom
adnanhemani wants to merge 2 commits intomainfrom
Conversation
…checksum verification
dimas-b
reviewed
Mar 19, 2026
Member
|
Can you verify that this works fine on both macOS and Linux? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this fix, the verify script deadlocks and stalls past a amount of artifacts processed during the Maven Repo Signature and Checksum Verification:
As I am no expert at this, I am relying on Claude's explanation that the process substitution used earlier doesn't close the pipe FDs reliably, which eventually ends up in a deadlock. The new code eliminates pipes altogether and therefore has nothing to leak.
If anyone has a better way of doing this, please suggest to raise a different PR - I am only going with this as this suggestion worked for me, but unsure if it is the correct long-term fix.
Checklist
CHANGELOG.md(if needed)site/content/in-dev/unreleased(if needed)