Use appropriate scope in producer methods#4031
Merged
adutra merged 1 commit intoapache:mainfrom Mar 20, 2026
Merged
Conversation
adutra
changed the title
Some producer methods are not annotated, which means that the produced beans get the `@Dependent` scope by default. This is incorrect for some of the beans. This PR fixes it.
adutra
force-pushed
the
fix-producer-method-scope
branch
from
03a4dd8 to
c10b903
Compare
dimas-b
approved these changes
Mar 19, 2026
| // Polaris service beans - selected from @Identifier-annotated beans | ||
|
|
||
| @Produces | ||
| @Singleton // used in instanceof checks |
Contributor
There was a problem hiding this comment.
instanceof on a CDI bean looks like an anti-pattern to me. This PR is still a good fix for the scope problem, but we should probably revisit those instanceof checks... WDYT?
Contributor
Author
There was a problem hiding this comment.
I agree. We have instanceof checks in production AND test code... but most test code. It's going to take some time to fix them all.
Contributor
There was a problem hiding this comment.
Sure. Let's do it gradually after this PR :)
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some producer methods are not annotated, which means that the produced beans get the
@Dependentscope by default. This is incorrect for some of the beans. This PR fixes it.Checklist
CHANGELOG.md(if needed)site/content/in-dev/unreleased(if needed)