Skip to content

[fix][io] Fix loading offset issues in Kafka Adaptor #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kasparjarek wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[fix][io] Fix loading offset issues in Kafka Adaptor #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions ...-adaptor/src/main/java/org/apache/pulsar/io/kafka/connect/AbstractKafkaConnectSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@
import org.apache.kafka.connect.source.SourceRecord;
import org.apache.kafka.connect.source.SourceTask;
import org.apache.kafka.connect.source.SourceTaskContext;
import org.apache.kafka.connect.json.JsonConverter;
import org.apache.kafka.connect.json.JsonConverterConfig;
import org.apache.kafka.connect.storage.Converter;
import org.apache.kafka.connect.storage.OffsetBackingStore;
import org.apache.kafka.connect.storage.OffsetStorageReader;
Expand Down Expand Up @@ -114,6 +116,15 @@ public void open(Map<String, Object> config, SourceContext sourceContext) throws
keyConverter.configure(config, true);
valueConverter.configure(config, false);

// initialize offset converters
Converter offsetKeyConverter = new JsonConverter();
Converter offsetValueConverter = new JsonConverter();

Map<String, Object> offsetConverterConfig = new HashMap<>();
offsetConverterConfig.put(JsonConverterConfig.SCHEMAS_ENABLE_CONFIG, false);
offsetKeyConverter.configure(offsetConverterConfig, true);
offsetValueConverter.configure(offsetConverterConfig, false);

offsetStore = new PulsarOffsetBackingStore(sourceContext.getPulsarClient());
PulsarKafkaWorkerConfig pulsarKafkaWorkerConfig = new PulsarKafkaWorkerConfig(stringConfig);
offsetStore.configure(pulsarKafkaWorkerConfig);
Expand All @@ -122,14 +133,14 @@ public void open(Map<String, Object> config, SourceContext sourceContext) throws
offsetReader = new OffsetStorageReaderImpl(
offsetStore,
"pulsar-kafka-connect-adaptor",
keyConverter,
valueConverter
offsetKeyConverter,
offsetValueConverter
);
offsetWriter = new OffsetStorageWriter(
offsetStore,
"pulsar-kafka-connect-adaptor",
keyConverter,
valueConverter
offsetKeyConverter,
offsetValueConverter
);

sourceTaskContext = new PulsarIOSourceTaskContext(offsetReader, pulsarKafkaWorkerConfig);
Expand Down