Add support for ipAddresses in TLS certificate templates#643
Merged
lhotari merged 3 commits intoapache:masterfrom Mar 20, 2026
Merged
Add support for ipAddresses in TLS certificate templates#643lhotari merged 3 commits intoapache:masterfrom
lhotari merged 3 commits intoapache:masterfrom
Conversation
lhotari
requested changes
Dec 15, 2025
Member
lhotari
left a comment
lhotari
left a comment
There was a problem hiding this comment.
Please document this new "feature" in charts/pulsar/values.yaml with commented out example values for broker and proxy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the TLS certificate template supports DNS names but does not allow specifying IP addresses. This makes it difficult to generate valid certificates for deployments that rely on IP-based access.
Modifications
ipAddressesincharts/pulsar/template/_certs.tpl.tls.<component>.ipAddressesis provided, it is rendered into the certificate spec.