add support for custom annotations on initialization Jobs#665
Merged
lhotari merged 1 commit intoapache:masterfrom Mar 18, 2026
Merged
add support for custom annotations on initialization Jobs#665lhotari merged 1 commit intoapache:masterfrom
lhotari merged 1 commit intoapache:masterfrom
Conversation
lhotari
approved these changes
Mar 18, 2026
Member
lhotari
left a comment
There was a problem hiding this comment.
LGTM, thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #664
Motivation
When upgrading Pulsar via Helm, ArgoCD sync fails because it attempts
to update immutable fields on the initialization Jobs
(
pulsar-cluster-initialize,bookkeeper-cluster-initialize,pulsar-manager-cluster-initialize). This requires manually deletingthe Jobs before every upgrade, which is error-prone and breaks
GitOps automation.
Supporting custom annotations on these Jobs allows users to control
how their CD tooling handles them. For example:
argocd.argoproj.io/hook: Syncandargocd.argoproj.io/hook-delete-policy: BeforeHookCreationcausesArgoCD to automatically delete and recreate the Job on each sync.
argocd.argoproj.io/sync-options: Replace=trueinstructsArgoCD to use
kubectl replaceinstead ofkubectl apply, avoidingthe immutable field conflict entirely.
Modifications
.Values.job.annotations(defaults to{}) invalues.yamlunder the existing
jobblock.metadatasection of:templates/pulsar-cluster-initialize.yamltemplates/bookkeeper-cluster-initialize.yamltemplates/pulsar-manager-cluster-initialize.yaml