Skip to content

fix: Improve Zookeeper initialization wait logic to support multi url configuration store #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ganeshkalyank wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −2
Open

fix: Improve Zookeeper initialization wait logic to support multi url configuration store #671

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions charts/pulsar/templates/pulsar-cluster-initialize.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,9 @@ spec:
command: ["timeout", "{{ .Values.pulsar_metadata.waitZookeeperTimeout }}", "sh", "-c"]
args:
- |
until nslookup {{ .Values.pulsar_metadata.configurationStore}}; do
sleep 3;
export PULSAR_MEM="-Xmx128M";
until timeout 15 bin/pulsar zookeeper-shell -server {{ .Values.pulsar_metadata.configurationStore }} ls /; do
echo "configurationStore {{ .Values.pulsar_metadata.configurationStore }} is unreachable... check in 3 seconds ..." && sleep 3;
Comment on lines +74 to +75
Copy link

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The readiness probe uses -server {{ .Values.pulsar_metadata.configurationStore }} directly, but the actual --configuration-store used later is built via pulsar.configurationStore.connect (which incorporates configurationStorePort). If configurationStorePort is customized (or differs from ZooKeeper’s default 2181), this loop may keep failing even though the configuration store endpoint used for initialization is reachable. Use the same connection string here as the initialization step (and quote it to avoid shell word-splitting).

Suggested change
until timeout 15 bin/pulsar zookeeper-shell -server {{ .Values.pulsar_metadata.configurationStore }} ls /; do
echo "configurationStore {{ .Values.pulsar_metadata.configurationStore }} is unreachable... check in 3 seconds ..." && sleep 3;
until timeout 15 bin/pulsar zookeeper-shell -server "{{ template "pulsar.configurationStore.connect" . }}" ls /; do
echo "configurationStore {{ template "pulsar.configurationStore.connect" . }} is unreachable... check in 3 seconds ..." && sleep 3;

Copilot uses AI. Check for mistakes.
done;
Comment on lines +73 to 76
Copy link

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait-zk-cs-ready now uses bin/pulsar zookeeper-shell to probe ZooKeeper, but it doesn’t apply the chart’s ZooKeeper TLS client settings. When .Values.tls.enabled and .Values.tls.zookeeper.enabled are true, this probe will fail even if the configuration store is reachable over TLS, blocking initialization. Consider including pulsar.toolset.zookeeper.tls.settings before invoking bin/pulsar (and ensure the initContainer mounts the toolset cert/CA volumes so those settings work).

Suggested change
export PULSAR_MEM="-Xmx128M";
until timeout 15 bin/pulsar zookeeper-shell -server {{ .Values.pulsar_metadata.configurationStore }} ls /; do
echo "configurationStore {{ .Values.pulsar_metadata.configurationStore }} is unreachable... check in 3 seconds ..." && sleep 3;
done;
export PULSAR_MEM="-Xmx128M";
{{- include "pulsar.toolset.zookeeper.tls.settings" . | nindent 12 }}
until timeout 15 bin/pulsar zookeeper-shell -server {{ .Values.pulsar_metadata.configurationStore }} ls /; do
echo "configurationStore {{ .Values.pulsar_metadata.configurationStore }} is unreachable... check in 3 seconds ..." && sleep 3;
done;
volumeMounts:
{{- include "pulsar.toolset.certs.volumeMounts" . | nindent 8 }}

Copilot uses AI. Check for mistakes.
{{- end }}
- name: wait-zk-metastore-ready
Expand Down
Loading