Skip to content

Fix typos in comments and test logs #26035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hiSandog wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −7
Open

Fix typos in comments and test logs #26035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1267,7 +1267,7 @@ public CmdFunctions(Supplier<PulsarAdmin> admin) throws PulsarClientException {
addCommand("restart", getRestarter());
addCommand("stop", getStopper());
addCommand("start", getStarter());
// TODO depecreate getstatus
// TODO deprecate getstatus
addCommand("status", getStatuser(), "getstatus");
addCommand("stats", getFunctionStats());
addCommand("list", getLister());
Expand Down
2 changes: 1 addition & 1 deletion pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSources.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ public CmdSources(Supplier<PulsarAdmin> admin) {
addCommand("update", updateSource);
addCommand("delete", deleteSource);
addCommand("get", getSource);
// TODO depecreate getstatus
// TODO deprecate getstatus
addCommand("status", getSourceStatus, "getstatus");
addCommand("list", listSources);
addCommand("stop", stopSource);
Expand Down
10 changes: 5 additions & 5 deletions ...rc/test/java/org/apache/pulsar/metadata/bookkeeper/LedgerUnderreplicationManagerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,7 +616,7 @@ public void testDisableLedgerReplication(String provider, Supplier<String> urlSu
AtomicInteger callbackCount = new AtomicInteger();
lum.notifyLedgerReplicationEnabled((rc, result) -> callbackCount.incrementAndGet());
lum.disableLedgerReplication();
log.info("Disabled Ledeger Replication");
log.info("Disabled Ledger Replication");

try {
lum.markLedgerUnderreplicated(ledgerA, missingReplica);
Expand All @@ -636,7 +636,7 @@ public void testDisableLedgerReplication(String provider, Supplier<String> urlSu
}

/**
* Test enabling the ledger re-replication. After enableLedegerReplication,
* Test enabling the ledger re-replication. After enableLedgerReplication,
* should continue getLedgerToRereplicate() task
*/
@Test(timeOut = 60000, dataProvider = "impl")
Expand All @@ -657,7 +657,7 @@ public void testEnableLedgerReplication(String provider, Supplier<String> urlSup
lum.notifyLedgerReplicationEnabled((rc, result) -> callbackCount.incrementAndGet());
// disabling replication
lum.disableLedgerReplication();
log.debug("Disabled Ledeger Replication");
log.debug("Disabled Ledger Replication");

String znodeA = getUrLedgerZnode(ledgerA);
final CountDownLatch znodeLatch = new CountDownLatch(2);
Expand All @@ -666,7 +666,7 @@ public void testEnableLedgerReplication(String provider, Supplier<String> urlSup
store.registerListener(n -> {
if (n.getType() == NotificationType.Created && n.getPath().equals(urLockLedgerA)) {
znodeLatch.countDown();
log.debug("Recieved node creation event for the zNodePath:" + n.getPath());
log.debug("Received node creation event for the zNodePath:" + n.getPath());
}
});

Expand All @@ -688,7 +688,7 @@ public void testEnableLedgerReplication(String provider, Supplier<String> urlSup

lum.enableLedgerReplication();
znodeLatch.await(5, TimeUnit.SECONDS);
log.debug("Enabled Ledeger Replication");
log.debug("Enabled Ledger Replication");
assertEquals(znodeLatch.getCount(), 0, "Failed to disable ledger replication!");
assertEquals(callbackCount.get(), 2, "Notify callback times mismatch");
} finally {
Expand Down
Loading