Skip to content

[fix][broker] Avoid blocking the PulsarAdmin callback thread on the post-unload load-report write #26061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
merlimat wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −3
Open

[fix][broker] Avoid blocking the PulsarAdmin callback thread on the post-unload load-report write #26061

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/ClustersBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -902,16 +902,18 @@ private CompletableFuture<Void> filterAndUnloadMatchedNamespaceAsync(String clus
List<CompletableFuture<Void>> futures = clusterLocalNamespaces.stream()
.map(namespaceName -> adminClient.namespaces().unloadAsync(namespaceName))
.collect(Collectors.toList());
return FutureUtil.waitForAll(futures).thenAccept(__ -> {
return FutureUtil.waitForAll(futures).thenAcceptAsync(__ -> {
try {
// write load info to load manager to make the load happens fast
// Write the load report so the unloaded namespaces rebalance quickly. Run it on the
// broker executor rather than the admin-client callback thread that completes the
// unload futures, because writeLoadReportOnZookeeper blocks on a metadata-store write.
pulsar().getLoadManager().get().writeLoadReportOnZookeeper(true);
} catch (Exception e) {
log.warn()
.exception(e)
.log("Failed to writeLoadReportOnZookeeper.");
}
});
}, pulsar().getExecutor());
});
}

Expand Down
Loading