Skip to content

[fix][broker] Avoid blocking the metrics thread on the pending-ack managed ledger #26062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
merlimat wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −3
Open

[fix][broker] Avoid blocking the metrics thread on the pending-ack managed ledger #26062

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions ...broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/TransactionAggregator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,15 @@ public static void generate(PulsarService pulsar, PrometheusMetricStreams stream
if (!isEventSystemTopic(TopicName.get(subscription.getTopic().getName()))
&& subscription instanceof PersistentSubscription
&& ((PersistentSubscription) subscription).checkIfPendingAckStoreInit()) {
// Use getNow() rather than get() so a not-yet-resolved managed
// ledger cannot block (and exhaust) the metrics thread pool; the
// stats are simply skipped for this scrape and picked up later.
ManagedLedger managedLedger = ((PersistentSubscription) subscription)
.getPendingAckManageLedger().get();
generateManageLedgerStats(managedLedger,
stream, cluster, namespace, name, subscription.getName());
.getPendingAckManageLedger().getNow(null);
if (managedLedger != null) {
generateManageLedgerStats(managedLedger,
stream, cluster, namespace, name, subscription.getName());
}
}
} catch (Exception e) {
log.warn()
Expand Down
Loading