RANGER-5365:Add test users into Ranger Docker Base Image#6
Merged
Conversation
Signed-off-by: Ramesh Mani <rmani@apache.org>
There was a problem hiding this comment.
Pull request overview
This pull request refactors user and group creation in the Ranger Docker base image by extracting the inline shell commands into a dedicated script, and adds test users (testuser1, testuser2, testuser3) in a testgroup to support testing scenarios.
- Replaces inline RUN commands with a reusable bash script for creating users and groups
- Adds test users (testuser1, testuser2, testuser3) and testgroup to the base image
- Consolidates user creation logic into helper functions for better maintainability
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| docker/create_users_and_groups.sh | New script that creates all required users and groups including the new test users with reusable helper functions |
| docker/Dockerfile | Removes inline user/group creation commands and integrates the new script for user setup |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kumaab
reviewed
Dec 31, 2025
mneethiraj
approved these changes
Dec 31, 2025
kumaab
approved these changes
Jan 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch is to include test users in the Ranger Base image to make those users available in ranger and associated containers