RANGER-5543:Ranger KMS GCP always try to create master key irrespective of its existence#910
Merged
dhavalshah9131 merged 2 commits intoapache:masterfrom Apr 14, 2026
Merged
Conversation
…ve of its existence
vikaskr22
reviewed
Apr 13, 2026
kms/src/main/java/org/apache/hadoop/crypto/key/RangerGoogleCloudHSMProvider.java
Outdated
Show resolved
Hide resolved
kms/src/main/java/org/apache/hadoop/crypto/key/RangerGoogleCloudHSMProvider.java
Outdated
Show resolved
Hide resolved
bhaveshamre
force-pushed
the
RANGER-5543
branch
2 times, most recently
from
2732af4 to
5e4eb49
Compare
vikaskr22
reviewed
Apr 13, 2026
kms/src/main/java/org/apache/hadoop/crypto/key/RangerGoogleCloudHSMProvider.java
Outdated
Show resolved
Hide resolved
…ve of its existence 2
bhaveshamre
force-pushed
the
RANGER-5543
branch
from
5e4eb49 to
d46932d
Compare
vikaskr22
approved these changes
Apr 13, 2026
Contributor
vikaskr22
left a comment
vikaskr22
left a comment
There was a problem hiding this comment.
LGTM now. Thanks @bhaveshamre .
dhavalshah9131
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added missing dependencies (guava, failureaccess, protobuf-java)
Fixed unnecessary master key creation by introducing masterKeyExists()
Implemented role-based logic:
Owner → creates key only if not exists
Viewer → only checks existence, no creation
How was this patch tested?
Built successfully using mvn clean compile package install. Manual testing was performed across multiple scenarios: when using the Owner role with a new key, the key was created successfully; with an existing key, no creation was attempted. For the Viewer role, the system correctly performed only existence checks for an existing key without attempting creation, and for a new key, no creation was attempted, resulting in a permission denied error as expected.