[ISSUE #10291] fix queryMessage default index type#10292
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #10292 +/- ##
=============================================
- Coverage 48.96% 48.88% -0.08%
+ Complexity 13464 13439 -25
=============================================
Files 1375 1375
Lines 100450 100450
Branches 12973 12973
=============================================
- Hits 49183 49104 -79
- Misses 45268 45326 +58
- Partials 5999 6020 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Fixes a regression in the client-side admin query path where queryMessage(clusterName, ..., isUniqKey=false) could return “no message” because the default indexType was null, causing local result filtering to drop all returned messages.
Changes:
- Default
indexTypebased onisUniqKeywhen calling the underlyingqueryMessage(..., indexType, lastKey)overload.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
321
to
324
| public QueryResult queryMessage(String clusterName, String topic, String key, int maxNum, long begin, long end, boolean isUniqKey) throws MQClientException, | ||
| InterruptedException { | ||
| return queryMessage(clusterName, topic, key, maxNum, begin, end, isUniqKey, null, null); | ||
| return queryMessage(clusterName, topic, key, maxNum, begin, end, isUniqKey, isUniqKey ? MessageConst.INDEX_UNIQUE_TYPE : MessageConst.INDEX_KEY_TYPE, null); | ||
| } |
yx9o
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Brief Description
How Did You Test This Change?