Skip to content

[ISSUE #10307] Feat: [DLedger] DLedgerCommitLog support dispatch LMQ #10308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
humkum wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[ISSUE #10307] Feat: [DLedger] DLedgerCommitLog support dispatch LMQ #10308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions store/src/main/java/org/apache/rocketmq/store/dledger/DLedgerCommitLog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,14 @@
import org.apache.rocketmq.store.CommitLog;
import org.apache.rocketmq.store.DefaultMessageStore;
import org.apache.rocketmq.store.DispatchRequest;
import org.apache.rocketmq.store.LmqDispatch;
import org.apache.rocketmq.store.MessageExtEncoder;
import org.apache.rocketmq.store.PutMessageResult;
import org.apache.rocketmq.store.PutMessageStatus;
import org.apache.rocketmq.store.SelectMappedBufferResult;
import org.apache.rocketmq.store.StoreStatsService;
import org.apache.rocketmq.store.config.MessageStoreConfig;
import org.apache.rocketmq.store.exception.ConsumeQueueException;
import org.apache.rocketmq.store.logfile.MappedFile;
import org.rocksdb.RocksDBException;

Expand Down Expand Up @@ -558,6 +560,21 @@ public CompletableFuture<PutMessageResult> asyncPutMessage(MessageExtBrokerInner
AppendFuture<AppendEntryResponse> dledgerFuture;
EncodeResult encodeResult;

final MessageStoreConfig storeConfig = this.defaultMessageStore.getMessageStoreConfig();
final boolean isMultiDispatchMsg = storeConfig.isEnableLmq() && msg.needDispatchLMQ();
if (isMultiDispatchMsg) {
try {
LmqDispatch.wrapLmqDispatch(this.defaultMessageStore, msg);
Copy link
Copy Markdown

@yangqikun-bd yangqikun-bd May 16, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe need to keep in lock? because it may cause data race by updateLmqOffsets

} catch (ConsumeQueueException e) {
log.error("Failed to wrap multi-dispatch for DLedger", e);
AppendMessageStatus status = e.getCause() instanceof RocksDBException
? AppendMessageStatus.ROCKSDB_ERROR
: AppendMessageStatus.UNKNOWN_ERROR;
return CompletableFuture.completedFuture(
new PutMessageResult(PutMessageStatus.UNKNOWN_ERROR, new AppendMessageResult(status)));
}
}

encodeResult = this.messageSerializer.serialize(msg);
if (encodeResult.status != AppendMessageStatus.PUT_OK) {
return CompletableFuture.completedFuture(new PutMessageResult(PutMessageStatus.MESSAGE_ILLEGAL, new AppendMessageResult(encodeResult.status)));
Expand Down Expand Up @@ -601,6 +618,13 @@ public CompletableFuture<PutMessageResult> asyncPutMessage(MessageExtBrokerInner
}

defaultMessageStore.increaseOffset(msg, getMessageNum(msg));
if (isMultiDispatchMsg) {
try {
LmqDispatch.updateLmqOffsets(this.defaultMessageStore, msg);
} catch (ConsumeQueueException e) {
log.error("Failed to update LMQ offsets for DLedger", e);
}
}
} catch (Exception e) {
log.error("Put message error", e);
return CompletableFuture.completedFuture(new PutMessageResult(PutMessageStatus.UNKNOWN_ERROR, new AppendMessageResult(AppendMessageStatus.UNKNOWN_ERROR)));
Expand Down
Loading