Skip to content

[BUG] Add logging to empty catch block in DefaultRecallMessageTraceHook #10363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
H145608 wants to merge 1 commit into
base: develop
Choose a base branch
from
+4 −1
Open

[BUG] Add logging to empty catch block in DefaultRecallMessageTraceHook #10363

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...nt/src/main/java/org/apache/rocketmq/client/trace/hook/DefaultRecallMessageTraceHook.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
package org.apache.rocketmq.client.trace.hook;

import org.apache.rocketmq.client.trace.TraceBean;
import org.apache.rocketmq.logging.org.slf4j.Logger;
import org.apache.rocketmq.logging.org.slf4j.LoggerFactory;
import org.apache.rocketmq.client.trace.TraceContext;
import org.apache.rocketmq.client.trace.TraceDispatcher;
import org.apache.rocketmq.client.trace.TraceType;
Expand All @@ -33,7 +35,7 @@
import java.util.ArrayList;

public class DefaultRecallMessageTraceHook implements RPCHook {

private static final Logger LOG = LoggerFactory.getLogger(DefaultRecallMessageTraceHook.class);
private static final String RECALL_TRACE_ENABLE_KEY = "com.rocketmq.recall.default.trace.enable";
private boolean enableDefaultTrace = Boolean.parseBoolean(System.getProperty(RECALL_TRACE_ENABLE_KEY, "false"));
private TraceDispatcher traceDispatcher;
Expand Down Expand Up @@ -80,6 +82,7 @@ public void doAfterResponse(String remoteAddr, RemotingCommand request, Remoting

traceDispatcher.append(traceContext);
} catch (Exception e) {
LOG.error("Failed to append recall trace context", e);
}
}
}