[fix]: Fix ReactorNettyWebSocketClient builder reuse in WebSocket plugin configuration#6330
Merged
Aias00 merged 4 commits intoapache:masterfrom Apr 24, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
WebSocketPluginConfigurationcurrently passes a mutableWebsocketClientSpec.Builderin a way that may cause builder state to be reused across WebSocket handshakes.Following the same approach discussed in Spring Cloud Gateway issue #2215 / PR #2216, each handshake should use a fresh builder instance to avoid cross-request state leakage.
Description
WebSocketPluginConfiguration#reactorNettyWebSocketClientto provide aSupplier<WebsocketClientSpec.Builder>that creates a new builder on each invocation.testReactorNettyWebSocketClient(as requested) to verify behavior by checking that the internal builder supplier returns different builder instances across calls.Related Links