bugfix(test): fix flaky ExecutorServiceSessionValidationSchedulerTest…#2820
Open
lprimak wants to merge 3 commits into
Open
bugfix(test): fix flaky ExecutorServiceSessionValidationSchedulerTest…#2820lprimak wants to merge 3 commits into
lprimak wants to merge 3 commits into
Conversation
github-actions
Bot
added
the
github_actions
steinarb
reviewed
Jun 29, 2026
| assertThat(defaultSessionManager.getActiveSessions()).isEmpty(); | ||
| await().atMost(Duration.ofSeconds(10)) | ||
| .pollInterval(Duration.ofMillis(100)) | ||
| .untilAsserted(() -> assertThat(defaultSessionManager.getActiveSessions()).isEmpty()); |
Contributor
There was a problem hiding this comment.
Had to read up on awaitatility. Nice!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… in core
Following this checklist to help us incorporate your contribution quickly and easily:
mvn verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like
[DOC] - Add javadoc in SessionManager.If this is your first contribution, you have to read the Contribution Guidelines
If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.
To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.