-
Notifications
You must be signed in to change notification settings - Fork 837
SOLR-18197: Add root document query shortcut support to NestPathField #4512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
abumarjikar
wants to merge
15
commits into
apache:main
Choose a base branch
from
abumarjikar:SOLR_18197_nest_path_easy_of_use
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
e306ef9
Initial Commit
abumarjikar b39e339
Merge branch 'main' into SOLR_18197_nest_path_easy_of_use
abumarjikar cdb63fd
Changed the type as suggested.
abumarjikar bbd24e3
Merge branch 'main' into SOLR_18197_nest_path_easy_of_use
abumarjikar c240e22
Merge branch 'main' into SOLR_18197_nest_path_easy_of_use
abumarjikar f3c86ff
Added Test and also null handling with bad request
abumarjikar e4ab909
Merge branch 'main' into SOLR_18197_nest_path_easy_of_use
abumarjikar ba79e8a
Changed the type as suggested.
abumarjikar 26866bc
Changed the type as suggested.
abumarjikar a457c03
Changes done as per the review.
abumarjikar cb632ee
Merge branch 'main' into SOLR_18197_nest_path_easy_of_use
abumarjikar 9da87be
changes made as per the review to have '/' by default
abumarjikar 35547e9
Changes made to use the shortcut for root lny docs search.
abumarjikar 8303718
Merge branch 'main' into SOLR_18197_nest_path_easy_of_use
abumarjikar 31b0676
Merge branch 'main' into SOLR_18197_nest_path_easy_of_use
abumarjikar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| title: Add root document query shortcut support to NestPathField | ||
| type: added | ||
| authors: | ||
| - name: Abhishek Umarjikar | ||
| nick: abumarjikar | ||
| links: | ||
| - name: SOLR-18197 | ||
| url: https://issues.apache.org/jira/browse/SOLR-18197 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
abumarjikar marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That change has a different underlying query & semantic effect. Formerly it found all docs separate from that parent path, thus matched not only the root doc but also
/aaand/ffif that exists, say. You changed it to only match documents at/aaexactly.