Skip to content

[Console] Batch delete expired application backups in cleanup task #4391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shangeyao wants to merge 1 commit into from
Closed

[Console] Batch delete expired application backups in cleanup task #4391

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 34 additions & 32 deletions ...ice/src/main/java/org/apache/streampark/console/core/task/ApplicationBackUpCleanTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,12 @@
import org.springframework.scheduling.annotation.Scheduled;
import org.springframework.stereotype.Component;

import java.util.ArrayList;
import java.util.Comparator;
import java.util.List;
import java.util.Map;
import java.util.stream.Collectors;

@Slf4j
@Component
@RequiredArgsConstructor
Expand All @@ -39,38 +45,34 @@ public class ApplicationBackUpCleanTask {
@Scheduled(cron = "${streampark.backup-clean.exec-cron:0 0 1 * * ?}")
public void backUpClean() {
log.info("Start to clean application backup");
// select all application backup which count > maxBackupNum group by app_id
backUpService.lambdaQuery()
.select(FlinkApplicationBackup::getAppId)
.groupBy(FlinkApplicationBackup::getAppId)
.having("COUNT(*) > {0}", maxBackupNum)
.list()
.stream()
.map(FlinkApplicationBackup::getAppId)
.forEach(
appId -> {
// order by create_time desc and skip first maxBackupNum records and delete
// others
backUpService.lambdaQuery()
.eq(FlinkApplicationBackup::getAppId, appId)
.orderByDesc(FlinkApplicationBackup::getCreateTime)
.list()
.stream()
.skip(maxBackupNum)
.forEach(
backUp -> {
try {
backUpService.removeById(
backUp.getId());
} catch (Exception e) {
log.error(
"Clean application backup failed for app id: {} , backup id: {}",
appId,
backUp.getId(),
e);
}
});
});
List<FlinkApplicationBackup> allBackups =
backUpService.lambdaQuery().orderByDesc(FlinkApplicationBackup::getCreateTime).list();
if (allBackups.isEmpty()) {
log.info("Clean application backup finished");
return;
}

Map<Long, List<FlinkApplicationBackup>> backupsByApp =
allBackups.stream().collect(Collectors.groupingBy(FlinkApplicationBackup::getAppId));

List<Long> toDelete = new ArrayList<>();
for (List<FlinkApplicationBackup> appBackups : backupsByApp.values()) {
appBackups.sort(Comparator.comparing(FlinkApplicationBackup::getCreateTime).reversed());
appBackups.stream()
.skip(maxBackupNum)
.map(FlinkApplicationBackup::getId)
.forEach(toDelete::add);
}

if (!toDelete.isEmpty()) {
try {
backUpService.removeByIds(toDelete);
log.info("Clean application backup finished, deleted {} records", toDelete.size());
} catch (Exception e) {
log.error("Clean application backup failed", e);
}
return;
}
log.info("Clean application backup finished");
}
}
Loading