Skip to content

feat: disable deprecated Graph editor tab by default#64

Merged
lukaszlenart merged 1 commit intomainfrom
feat/disable-graph-editor-by-default
Apr 5, 2026
Merged

feat: disable deprecated Graph editor tab by default#64
lukaszlenart merged 1 commit intomainfrom
feat/disable-graph-editor-by-default

Conversation

@lukaszlenart
Copy link
Copy Markdown
Member

@lukaszlenart lukaszlenart commented Apr 5, 2026

Summary

  • Disable the deprecated Graph editor tab by default to prevent IDE freezes caused by the legacy GraphBuilder/GraphBuilderFactory APIs on newer IntelliJ Platform versions.
  • Gate the feature behind a JVM system property (-Dcom.intellij.struts2.enableGraphEditor=true) so users who need the graph view can still opt in.
  • Document the opt-in flag in README and CHANGELOG.

Changes

  • Struts2GraphFileEditorProvider.java: Add early isGraphEditorEnabled() check in accept() that returns false when the JVM property is absent or false.
  • README.md: Add "Optional features" section explaining how to re-enable the graph tab.
  • CHANGELOG.md: Add entry under [Unreleased].

Test plan

  • Build the plugin (./gradlew compileJava) -- verified, passes with no new warnings
  • Open a struts.xml file without the JVM flag -- Graph tab should not appear
  • Start IDE with -Dcom.intellij.struts2.enableGraphEditor=true -- Graph tab should appear
  • With the flag enabled, verify the graph tab behaves as before

Made with Cursor

The Graph editor tab uses deprecated IntelliJ Platform APIs
(GraphBuilder, GraphBuilderFactory) that can cause IDE freezes on
newer platform versions. Gate the feature behind a JVM system property
so it is hidden by default. Users who need the graph view can opt in
with -Dcom.intellij.struts2.enableGraphEditor=true via
Help | Edit Custom VM Options.

Made-with: Cursor
@lukaszlenart lukaszlenart marked this pull request as ready for review April 5, 2026 08:17
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 5, 2026

🔌 Plugin artifact ready for testing!

Download from Actions artifacts

Artifact: struts2-261.18970.1

@lukaszlenart lukaszlenart merged commit 3476c45 into main Apr 5, 2026
5 checks passed
@lukaszlenart lukaszlenart deleted the feat/disable-graph-editor-by-default branch April 5, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant