feat(annotator): warn when Web facet is missing for Struts modules#67
Open
lukaszlenart wants to merge 1 commit intomainfrom
Open
feat(annotator): warn when Web facet is missing for Struts modules#67lukaszlenart wants to merge 1 commit intomainfrom
lukaszlenart wants to merge 1 commit intomainfrom
Conversation
Adds early feedback when a Struts-configured module has no WebFacet, which prevents JSP result path resolution and Diagram navigation. - WebFacetChecker: shared predicate reused by annotator and initializer - StrutsWebFacetCheckingAnnotator: file-level warning on struts.xml with quick action to open module facet settings - StrutsFrameworkInitializer: one-time notification per affected module on project open - Struts2ProjectDescriptorBuilder.withoutWebFacet(): test support for omitting WebFacet in light tests Follow-up to PR #66 (DTD validation). Made-with: Cursor
|
🔌 Plugin artifact ready for testing! Download from Actions artifacts Artifact: |
lukaszlenart
requested review from
aleksandr-m,
cnenning,
jogep,
kusalk,
rgielen,
sdutry and
yasserzamani
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #66 (DTD validation). Adds early feedback when a Struts-configured module lacks a Web facet, which prevents JSP result path resolution and Diagram navigation from working.
WebFacetChecker– shared predicate reused by the annotator and framework initializerStrutsWebFacetCheckingAnnotator– file-level warning onstruts.xmlfiles with a quick action to open module facet settingsStrutsFrameworkInitializer– one-time notification per affected module on project openStruts2ProjectDescriptorBuilder.withoutWebFacet()– test-infrastructure support for omittingWebFacetin light testsStrutsWebFacetCheckingAnnotatorTest,WebFacetCheckerTestTest plan
./gradlew test -x ratpasses (full suite)Made with Cursor