refactor(facet): migrate FacetConfiguration persistence to PersistentStateComponent#68
Open
lukaszlenart wants to merge 1 commit intomainfrom
Open
refactor(facet): migrate FacetConfiguration persistence to PersistentStateComponent#68lukaszlenart wants to merge 1 commit intomainfrom
lukaszlenart wants to merge 1 commit intomainfrom
Conversation
…StateComponent Replace deprecated readExternal()/writeExternal() overrides in StrutsFacetConfiguration with PersistentStateComponent<Element>, following the migration path documented in the IntelliJ Platform SDK. Uses PersistentStateComponent<Element> to preserve the exact existing XML structure (fileset/file/propertiesKeys tags) for full backward compatibility with saved .iml facet configuration. Also removes redundant ModificationTracker interface (already inherited from SimpleModificationTracker superclass). Made-with: Cursor
|
🔌 Plugin artifact ready for testing! Download from Actions artifacts Artifact: |
lukaszlenart
requested review from
aleksandr-m,
cnenning,
jogep,
kusalk,
rgielen,
sdutry and
yasserzamani
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FacetConfiguration.readExternal()/writeExternal()overrides inStrutsFacetConfigurationwithPersistentStateComponent<Element>, the migration path documented in the IntelliJ Platform SDKPersistentStateComponent<Element>(raw JDOM) to preserve the exact existing XML structure (<fileset>,<file>,<propertiesKeys>tags) for full backward compatibility with saved.imlfacet configurationModificationTrackerinterface (already inherited fromSimpleModificationTrackersuperclass)framework-initialization.mdandCHANGELOG.mdto reflect the new APITest plan
./gradlew test --tests "StrutsFacetConfigurationTest" -x rat— all 7 new tests pass./gradlew test -x rat— full test suite passes with no regressions./gradlew compileJava— zero deprecation warnings fromStrutsFacetConfigurationMade with Cursor