refactor(facet): replace deprecated CheckboxTreeBase constructor with explicit CheckPolicy#69
Open
lukaszlenart wants to merge 1 commit intomainfrom
Open
refactor(facet): replace deprecated CheckboxTreeBase constructor with explicit CheckPolicy#69lukaszlenart wants to merge 1 commit intomainfrom
lukaszlenart wants to merge 1 commit intomainfrom
Conversation
… explicit CheckPolicy The 2-arg CheckboxTreeBase(renderer, root) constructor is deprecated in IntelliJ Platform 2026.1 because it relies on an implicit default check policy. Replace it with the non-deprecated 3-arg form that takes an explicit CheckPolicy matching the previous default behavior (checkChildren=true, uncheckChildren=true, checkParent=false, uncheckParent=true). Made-with: Cursor
lukaszlenart
requested review from
aleksandr-m,
cnenning,
jogep,
kusalk,
rgielen,
sdutry and
yasserzamani
|
🔌 Plugin artifact ready for testing! Download from Actions artifacts Artifact: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CheckboxTreeBase(renderer, root)constructor inStrutsFilesTreewith the non-deprecated 3-arg form that accepts an explicitCheckPolicytrue, true, false, true) exactly replicate the platform's previous implicit default, so checkbox propagation behavior in the facet file-set editor is unchanged@SuppressWarnings("deprecation")annotation that is no longer neededContext
The
CheckboxTreeBase(renderer, root)constructor was deprecated in IntelliJ Platform 2026.1 because it hides the check-propagation policy behind an internal default. The non-deprecated 3-arg constructor requires callers to specify aCheckPolicyexplicitly.Default values were confirmed by decompiling the 261 SDK's
CheckboxTreeHelper.DEFAULT_POLICY:checkChildrenWithCheckedParent = trueuncheckChildrenWithUncheckedParent = truecheckParentWithCheckedChild = falseuncheckParentWithUncheckedChild = trueTest plan
./gradlew compileJavasucceeds with no new deprecation warnings./gradlew test -x ratpasses (all existing tests green)Made with Cursor