refactor: replace deprecated EXTEND_CLASS_NAMES with SUPER_CLASSES#70
Open
lukaszlenart wants to merge 1 commit intomainfrom
Open
refactor: replace deprecated EXTEND_CLASS_NAMES with SUPER_CLASSES#70lukaszlenart wants to merge 1 commit intomainfrom
lukaszlenart wants to merge 1 commit intomainfrom
Conversation
Replace JavaClassReferenceProvider.EXTEND_CLASS_NAMES (deprecated, scheduled for removal) with the supported SUPER_CLASSES option in ConstantValueClassConverter. Guard the option so it is only set when baseClass is non-empty, preserving the existing "any concrete non-interface class" semantics for constants like struts.configuration and struts.mapper.class that intentionally pass "". 🤖 Generated by AI Assistant Made-with: Cursor
|
🔌 Plugin artifact ready for testing! Download from Actions artifacts Artifact: |
lukaszlenart
requested review from
aleksandr-m,
cnenning,
jogep,
kusalk,
rgielen,
sdutry and
yasserzamani
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JavaClassReferenceProvider.EXTEND_CLASS_NAMESoption with the supportedSUPER_CLASSESoption inConstantValueClassConverterSUPER_CLASSESassignment so it is only set whenbaseClassis non-empty, preserving the existing "any concrete non-interface class" semantics for constants that intentionally pass""(e.g.struts.configuration,struts.mapper.class)//noinspection deprecationsuppression and TODO commentTest plan
StrutsConstantManagerWithStrutsPluginXmlTestpasses (exercises restricted base-class path viastruts.objectFactory)*StrutsConstant*tests passEXTEND_CLASS_NAMESin source treeMade with Cursor