Harden showcase apps and convert READMEs to Markdown#1624
Draft
lukaszlenart wants to merge 1 commit intomainfrom
Draft
Harden showcase apps and convert READMEs to Markdown#1624lukaszlenart wants to merge 1 commit intomainfrom
lukaszlenart wants to merge 1 commit intomainfrom
Conversation
- Add production deployment warnings to showcase and rest-showcase READMEs - Convert README.txt to README.md with proper Markdown formatting - Restrict ViewSourceAction config parameter to XML files within webapp path Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
README.txttoREADME.mdwith proper Markdown formattingViewSourceActionby restricting theconfigparameter to only read.xmlfiles within the webapp's deployment directory, preventing arbitrary file reads via craftedfile:///URIsTest plan
mvn compile -pl apps/showcaseviewSource.actionstill displays struts.xml config snippets correctlyconfigparameter with paths outside webapp root returns no content🤖 Generated with Claude Code