fix(trino): cancel_query doesn't abort query execution in Trino server#24913
fix(trino): cancel_query doesn't abort query execution in Trino server#24913dungdm93 wants to merge 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24913 +/- ##
==========================================
- Coverage 69.00% 68.99% -0.01%
==========================================
Files 1906 1906
Lines 74134 74144 +10
Branches 8208 8208
==========================================
+ Hits 51153 51154 +1
- Misses 20858 20867 +9
Partials 2123 2123
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
2b40022 to
62c9778
Compare
|
The linked Trino PR still hasn't been merged, but the linked Superset Issue has been closed as resolved by #25680. Should we close this, or is there more to unpack here? |
|
@rusackas we wrote #25680 to work around the trino client lib being blocking, but a more "ideal" solution would be to allow the trino client lib to not block and then handle it in a simpler way (this solution). If these two PRs get to a state where they can be merged it's probably a neater solution. It looks like they've been abandoned though, so unless someone is invested in taking them over we can probably stick with the solution we already have. |
|
I'll close this one per above, can always be reopened / adapted if changes go into the trino library to allow us simpler usage here. |
SUMMARY
Fix #24858
This PR has 2 parts: Superset part - this PR, Trino part: trinodb/trino-python-client#400
Waiting for trinodb/trino-python-client#400 merge first and I'll bump the trino version
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
Screencast.from.08-08-2023.16.17.37.webm
After:
Screencast.from.08-08-2023.16.07.09.webm
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION