feat(workflow-operator): add Python UDF UI parameter injection model#5141
Open
carloea2 wants to merge 3 commits into
Open
feat(workflow-operator): add Python UDF UI parameter injection model#5141carloea2 wants to merge 3 commits into
carloea2 wants to merge 3 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5141 +/- ##
============================================
+ Coverage 43.34% 43.44% +0.10%
- Complexity 2213 2215 +2
============================================
Files 1049 1051 +2
Lines 40561 40644 +83
Branches 4322 4335 +13
============================================
+ Hits 17581 17658 +77
Misses 21888 21888
- Partials 1092 1098 +6
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
This PR adds the Scala backend foundation for Python UDF UI parameters.
It introduces:
UiUDFParameter, containing backend-compatibleattributemetadata and an editablevalue.PythonUdfUiParameterInjector, which validates UI parameters and injects a reserved hook method into supported Python UDF classes.Attribute.getName()as encodable so UI parameter names are safely rendered through the Python template builder.This PR is stacked after the merged frontend foundation PR #5043. It does not yet wire the injector into operator execution; that wiring is handled by later PRs in the stack.
Existing Python UDF workflow execution remains unchanged in this PR because
PythonUDFOpDescV2,PythonUDFSourceOpDescV2, andDualInputPortsPythonUDFOpDescV2are not modified here.Any related issues, documentation, discussions?
Part of the Python UDF UI parameter feature split from
feat/ui-parameter.Related tracking issue / stack: #5044
Stack order:
How was this PR tested?
Commands run:
Results:
PythonUdfUiParameterInjectorSpec: 10 tests passed.scalafmtAll: no file changes.scalafmtCheckAllandscalafixAll --check: passed.Was this PR authored or co-authored using generative AI tooling?
No