Skip to content

fix(BarChart, v1.2): treat an empty categoryColumn as no category (px.bar color) #6997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yicong-Huang wants to merge 1 commit into
base: release/v1.2
Choose a base branch
from
+13 −1
Open

fix(BarChart, v1.2): treat an empty categoryColumn as no category (px.bar color) #6997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...c/main/scala/org/apache/texera/amber/operator/visualization/barChart/BarChartOpDesc.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,9 @@ class BarChartOpDesc extends PythonOperatorDescriptor {
isPatternSelected = "True"

var isCategoryColumn = "False"
if (categoryColumn != "No Selection")
// "" is the Scala default ("No Selection" is only JSON metadata); an empty
// column must also count as "no category", else px.bar(color="") fails.
if (categoryColumn.nonEmpty && categoryColumn != "No Selection")
isCategoryColumn = "True"

val finalCode =
Expand Down
10 changes: 10 additions & 0 deletions ...st/scala/org/apache/texera/amber/operator/visualization/barChart/BarChartOpDescSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,4 +110,14 @@ class BarChartOpDescSpec extends AnyFlatSpec with BeforeAndAfter with Matchers {
ex.getMessage should (include("Value column") or include("Fields"))
}

"BarChartOpDesc.generatePythonCode" should "treat an unset categoryColumn as no category (color guarded to None)" in {
// An empty categoryColumn (its Scala default) must guard color to None, not
// emit `... if True else None` with an empty column name for px.bar(color=).
opDesc.value = "score"
opDesc.fields = "name"
val code = opDesc.generatePythonCode()
code should include("color=self.decode_python_template('') if False else None")
code should not include "color=self.decode_python_template('') if True else None"
}

}
Loading