fix(local-dev, v1.2): refresh Lakekeeper warehouse S3 endpoint when it already exists - #6999
Open
Yicong-Huang wants to merge 1 commit into
Open
Conversation
…ady exists (#6197) ### What changes were proposed in this PR? Makes `lakekeeper-init` (in `bin/single-node/docker-compose.yml`) keep the Iceberg warehouse's S3 endpoint in sync with the current `STORAGE_S3_ENDPOINT`. The warehouse persists its endpoint in Lakekeeper's own DB; `local-dev` sets `STORAGE_S3_ENDPOINT` to the host **LAN IP** (not `localhost`) so both the containerized Lakekeeper and the host JVMs — which reach MinIO directly via Iceberg remote-signing — use the same address. But that IP changes across networks / DHCP leases, and the init was idempotent: it **skipped** the warehouse when it already existed, so the stale endpoint was never refreshed. Workflow execution then failed with an opaque `org.apache.iceberg.exceptions.RESTException: Unable to process` at `createTable`. Instead of skipping, the existing-warehouse branch now `POST`s the current endpoint + credentials to `/management/v1/warehouse/{id}/storage` on every run. This is non-destructive and preserves existing Iceberg tables (their metadata stores `s3://bucket/...` paths, not the endpoint). ### Any related issues, documentation, discussions? Closes #6195 ### How was this PR tested? - Verified the same `POST /management/v1/warehouse/{id}/storage` call heals a live stack whose warehouse had a stale IP: it returned HTTP 200 and the vended endpoint updated to the current host IP, after which workflow execution succeeded. - `docker compose -f bin/single-node/docker-compose.yml config -q` validates the file. - Extracted the rendered `lakekeeper-init` command and confirmed `bash -n` passes (after applying compose's runtime `$$`→`$` unescaping), so the added heredoc/shell is syntactically sound. ### Was this PR authored or co-authored using generative AI tooling? (backported from commit aaed085) Generated-by: Claude Opus 4.8 (1M context)
Contributor
Automated Reviewer SuggestionsBased on the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Backport of #6197 to
release/v1.2, cherry-picked from aaed085. The cherry-pick applied cleanly.Follows the Direct Backport Push convention; opened as a PR (rather than a direct push) per a backport-coverage audit.
Any related issues, documentation, discussions?
Backport of #6197. Originally linked #6195.
How was this PR tested?
Release-branch CI runs on this PR. Cherry-pick applied cleanly onto
release/v1.2; no manual conflict resolution was needed.Was this PR authored or co-authored using generative AI tooling?
Yes — backport prepared with Claude Code (mechanical cherry-pick; the change itself is #6197 by its original author).
🤖 Generated with Claude Code