Skip to content

fix(TablesPlot, v1.2): join selected columns with a comma to emit valid Python #7004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yicong-Huang wants to merge 1 commit into
base: release/v1.2
Choose a base branch
from
+4 −1
Open

fix(TablesPlot, v1.2): join selected columns with a comma to emit valid Python #7004

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...n/scala/org/apache/texera/amber/operator/visualization/tablesChart/TablesPlotOpDesc.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,10 @@ class TablesPlotOpDesc extends PythonOperatorDescriptor {
var includedColumns: List[TablesConfig] = List()

private def getAttributes: String =
includedColumns.map(c => pyb"""${c.attributeName}""").mkString("','")
// Join with a plain comma: each column renders to a decode_python_template(...)
// call, so joining with the literal ',' would put a string right after a call
// and produce invalid Python.
includedColumns.map(c => pyb"""${c.attributeName}""").mkString(",")

def manipulateTable(): PythonTemplateBuilder = {
assert(includedColumns.nonEmpty)
Expand Down
Loading