Skip to content

fix(ci): rename backport auto-label output so its report step runs - #7022

Queued
Yicong-Huang wants to merge 1 commit into
apache:mainfrom
Yicong-Huang:fix/backport-auto-label-output-collision
Queued

fix(ci): rename backport auto-label output so its report step runs#7022
Yicong-Huang wants to merge 1 commit into
apache:mainfrom
Yicong-Huang:fix/backport-auto-label-output-collision

Conversation

@Yicong-Huang

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

The Report backport decisions step in backport-auto-label.yml is skipped on every run, so the report comment and release-manager review request added in #6962 never fire.

Root cause: the step's guard reads steps.label.outputs.result. actions/github-script always writes the script's return value to an output named result after the body runs. The Label fix PRs script has no return, so that post-run write blanks out the explicit core.setOutput("result", …) — the guard is therefore always false.

Fix: rename the output to decisions (github-script only reserves result), and update the guard and the RESULT env reference to match. No logic in either step changes.

Any related issues, documentation, discussions?

Closes #7021.

How was this PR tested?

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Claude Opus 4.8)

The `Report backport decisions` step is skipped on every run because its
guard reads `steps.label.outputs.result`. actions/github-script always
writes the script's return value to an output named `result` after the
body runs; the Label step returns nothing, so that write blanks out the
explicit `core.setOutput("result", …)` and the guard is always false.

Rename the output to `decisions` (github-script only reserves `result`)
so the report comment and release-manager review request from apache#6962
actually fire.

Closes apache#7021

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added fix ci changes related to CI labels Jul 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • No candidates found from git blame history.

@codecov-commenter

codecov-commenter commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.10%. Comparing base (469e8f0) to head (7cffa27).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7022      +/-   ##
============================================
+ Coverage     78.99%   79.10%   +0.10%     
  Complexity     3788     3788              
============================================
  Files          1160     1160              
  Lines         46105    46108       +3     
  Branches       5115     5117       +2     
============================================
+ Hits          36419    36472      +53     
+ Misses         8067     8009      -58     
- Partials       1619     1627       +8     
Flag Coverage Δ
access-control-service 70.00% <ø> (ø)
agent-service 76.76% <ø> (ø)
amber 72.27% <ø> (+0.06%) ⬆️
computing-unit-managing-service 20.49% <ø> (ø)
config-service 66.66% <ø> (ø)
file-service 67.21% <ø> (ø)
frontend 82.99% <ø> (-0.01%) ⬇️
notebook-migration-service 78.94% <ø> (ø)
pyamber 96.29% <ø> (+0.90%) ⬆️
workflow-compiling-service 26.31% <ø> (ø)

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

✅ No material benchmark regressions detected

🟢 4 better · 🔴 0 worse · ⚪ 11 noise (<±5%) · 0 without baseline

Compared against main 812f177 benchmarked on this same runner, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.

Dashboard · Run

config throughput MB/s latency max Δ latest / 7d
🟢 bs=10 sw=10 sl=64 365 0.223 25,816/39,271/39,271 us 🟢 -11.4% / 🔴 +148.5%
🟢 bs=100 sw=10 sl=64 789 0.481 128,278/141,295/141,295 us 🟢 -12.6% / 🔴 +31.7%
bs=1000 sw=10 sl=64 897 0.548 1,106,410/1,163,846/1,163,846 us ⚪ within ±5% / 🔴 +13.3%
Baseline details

Latest main 812f177 from same runner

config metric PR latest main 7d avg Δ latest Δ 7d
bs=10 sw=10 sl=64 throughput 365 tuples/sec 358 tuples/sec 787.55 tuples/sec +2.0% -53.7%
bs=10 sw=10 sl=64 MB/s 0.223 MB/s 0.219 MB/s 0.481 MB/s +1.8% -53.6%
bs=10 sw=10 sl=64 p50 25,816 us 25,289 us 12,255 us +2.1% +110.7%
bs=10 sw=10 sl=64 p95 39,271 us 44,307 us 15,802 us -11.4% +148.5%
bs=10 sw=10 sl=64 p99 39,271 us 44,307 us 19,008 us -11.4% +106.6%
bs=100 sw=10 sl=64 throughput 789 tuples/sec 774 tuples/sec 997.81 tuples/sec +1.9% -20.9%
bs=100 sw=10 sl=64 MB/s 0.481 MB/s 0.472 MB/s 0.609 MB/s +1.9% -21.0%
bs=100 sw=10 sl=64 p50 128,278 us 123,541 us 100,690 us +3.8% +27.4%
bs=100 sw=10 sl=64 p95 141,295 us 161,728 us 107,316 us -12.6% +31.7%
bs=100 sw=10 sl=64 p99 141,295 us 161,728 us 113,823 us -12.6% +24.1%
bs=1000 sw=10 sl=64 throughput 897 tuples/sec 916 tuples/sec 1,030 tuples/sec -2.1% -12.9%
bs=1000 sw=10 sl=64 MB/s 0.548 MB/s 0.559 MB/s 0.629 MB/s -2.0% -12.9%
bs=1000 sw=10 sl=64 p50 1,106,410 us 1,089,286 us 981,213 us +1.6% +12.8%
bs=1000 sw=10 sl=64 p95 1,163,846 us 1,155,692 us 1,027,605 us +0.7% +13.3%
bs=1000 sw=10 sl=64 p99 1,163,846 us 1,155,692 us 1,055,466 us +0.7% +10.3%
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,548.18,200,128000,365,0.223,25816.01,39271.07,39271.07
1,100,10,64,20,2535.22,2000,1280000,789,0.481,128278.41,141295.25,141295.25
2,1000,10,64,20,22284.15,20000,12800000,897,0.548,1106409.79,1163846.07,1163846.07

@Yicong-Huang
Yicong-Huang added this pull request to the merge queue Jul 29, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Jul 29, 2026
@Yicong-Huang
Yicong-Huang added this pull request to the merge queue Jul 29, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Jul 29, 2026
@aglinxinyuan
aglinxinyuan added this pull request to the merge queue Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci changes related to CI fix

Projects

None yet

3 participants