fix(ci): rename backport auto-label output so its report step runs - #7022
Queued
Yicong-Huang wants to merge 1 commit into
Queued
fix(ci): rename backport auto-label output so its report step runs#7022Yicong-Huang wants to merge 1 commit into
Yicong-Huang wants to merge 1 commit into
Conversation
The `Report backport decisions` step is skipped on every run because its
guard reads `steps.label.outputs.result`. actions/github-script always
writes the script's return value to an output named `result` after the
body runs; the Label step returns nothing, so that write blanks out the
explicit `core.setOutput("result", …)` and the guard is always false.
Rename the output to `decisions` (github-script only reserves `result`)
so the report comment and release-manager review request from apache#6962
actually fire.
Closes apache#7021
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7022 +/- ##
============================================
+ Coverage 78.99% 79.10% +0.10%
Complexity 3788 3788
============================================
Files 1160 1160
Lines 46105 46108 +3
Branches 5115 5117 +2
============================================
+ Hits 36419 36472 +53
+ Misses 8067 8009 -58
- Partials 1619 1627 +8
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
✅ No material benchmark regressions detected🟢 4 better · 🔴 0 worse · ⚪ 11 noise (<±5%) · 0 without baseline
Baseline detailsLatest main
Raw CSVconfig_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,548.18,200,128000,365,0.223,25816.01,39271.07,39271.07
1,100,10,64,20,2535.22,2000,1280000,789,0.481,128278.41,141295.25,141295.25
2,1000,10,64,20,22284.15,20000,12800000,897,0.548,1106409.79,1163846.07,1163846.07 |
aglinxinyuan
approved these changes
Jul 29, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Jul 29, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
The
Report backport decisionsstep inbackport-auto-label.ymlis skipped on every run, so the report comment and release-manager review request added in #6962 never fire.Root cause: the step's guard reads
steps.label.outputs.result.actions/github-scriptalways writes the script's return value to an output namedresultafter the body runs. TheLabel fix PRsscript has noreturn, so that post-run write blanks out the explicitcore.setOutput("result", …)— the guard is therefore always false.Fix: rename the output to
decisions(github-script only reservesresult), and update the guard and theRESULTenv reference to match. No logic in either step changes.Any related issues, documentation, discussions?
Closes #7021.
How was this PR tested?
30423275226(PR fix(workflow-operator): re-validate redirect hops in HF remote-URL fetches to close an SSRF bypass #7013): theReport backport decisionsstep showsskipped.<!-- backport-auto-label-report -->comments across fix(workflow-operator): re-validate redirect hops in HF remote-URL fetches to close an SSRF bypass #7013, fix(docs): use a plain year range in NOTICE copyright #6983, fix: Add missing license headers to Docs #6958, fix(deps, frontend): update dependency ajv to v8.18.0 [security] #6908 (including PRs that were auto-labeled), confirming the step is systemically skipped.Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 4.8)