Skip to content

refactor(config): replace the hand-rolled AuthConfig secret lock with lazy val #7040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aglinxinyuan merged 2 commits into from
Jul 30, 2026
+6 −14
Merged

refactor(config): replace the hand-rolled AuthConfig secret lock with lazy val #7040

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
205b0d9
refactor(config): replace the hand-rolled AuthConfig secret lock with…
aglinxinyuan Jul 29, 2026
8a81451
Merge branch 'main' into replace-authconfig-dcl-with-lazy-val
Yicong-Huang Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 6 additions & 14 deletions common/config/src/main/scala/org/apache/texera/common/config/AuthConfig.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,20 +28,12 @@ object AuthConfig {
// Read jwt Expiration time in minutes
final val jwtExpirationMinutes: Int = conf.getInt("auth.jwt.expiration-in-minutes")

// For storing the generated/configured secret
@volatile private var secretKey: String = _

// Read JWT secret key with support for random generation
def jwtSecretKey: String = {
synchronized {
if (secretKey == null) {
secretKey = conf.getString("auth.jwt.256-bit-secret").toLowerCase() match {
case "random" => getRandomHexString
case key => key
}
}
}
secretKey
// Read JWT secret key with support for random generation.
// `lazy val` already compiles to a thread-safe, initialize-once accessor, so it
// replaces the hand-rolled @volatile + synchronized double-checked lock.
lazy val jwtSecretKey: String = conf.getString("auth.jwt.256-bit-secret").toLowerCase() match {
case "random" => getRandomHexString
case key => key
}

private def getRandomHexString: String = {
Expand Down
Loading