Skip to content

ci: skip contributor template check for renovate-bot's User account - #7062

Merged
Yicong-Huang merged 1 commit into
apache:mainfrom
Yicong-Huang:fix/template-check-skip-renovate-bot
Jul 29, 2026
Merged

ci: skip contributor template check for renovate-bot's User account#7062
Yicong-Huang merged 1 commit into
apache:mainfrom
Yicong-Huang:fix/template-check-skip-renovate-bot

Conversation

@Yicong-Huang

@Yicong-Huang Yicong-Huang commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

The contributor-checks job in .github/workflows/contributor-checks.yml gates on github.event.sender.type != 'Bot' so it won't nag automated PR/issue openers about not following the contribution template.

That gate catches GitHub App bots (e.g. dependabot[bot], whose account type is Bot) but not Renovate, which on this repo runs under a regular User account: renovate-bot has type: User, so it slips through and gets the "the description doesn't follow our template" warning on every dependency-update PR (example: #7060).

This PR excludes renovate-bot explicitly by login:

if: >-
  github.event.sender.type != 'Bot' &&
  github.event.sender.login != 'renovate-bot'

Any related issues, documentation, discussions?

Closes #7063.

Example of the false warning: #7060.

How was this PR tested?

  • Confirmed via the GitHub API that renovate-bot has type: User (not Bot), which is why the existing sender.type != 'Bot' gate did not exclude it.
  • Validated the workflow YAML parses and the folded if: expression resolves to the intended single-line condition.
  • The change is confined to the job-level if: gate; no run: step or untrusted-input interpolation is touched.

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Opus 4.8)

@github-actions github-actions Bot added fix ci changes related to CI labels Jul 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • No candidates found from git blame history.

The contributor-checks job gated on `sender.type != 'Bot'` to avoid
nagging automated PR/issue openers about the template. That catches
GitHub App bots (dependabot) but not Renovate, which runs under a
regular User account (`renovate-bot`, type: User) and so slipped
through and got the "description doesn't follow the template" warning
on its dependency-update PRs.

Exclude `renovate-bot` explicitly by login.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@Yicong-Huang
Yicong-Huang force-pushed the fix/template-check-skip-renovate-bot branch from 5f0a223 to 2c5f48c Compare July 29, 2026 21:43
@Yicong-Huang Yicong-Huang changed the title Skip contributor template check for bot User accounts (e.g. renovate-bot) Skip contributor template check for renovate-bot Jul 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Benchmark changes need a look

🟢 4 better · 🔴 2 worse · ⚪ 9 noise (<±5%) · 0 without baseline

Compared against main 02ae12b benchmarked on this same runner, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.

Dashboard · Run

config throughput MB/s latency max Δ latest / 7d
🔴 bs=10 sw=10 sl=64 551 0.336 17,573/23,210/23,210 us 🔴 +8.1% / 🔴 +47.1%
🔴 bs=100 sw=10 sl=64 1,191 0.727 82,464/111,035/111,035 us 🔴 +6.6% / 🟢 +19.1%
bs=1000 sw=10 sl=64 1,422 0.868 697,398/743,145/743,145 us ⚪ within ±5% / 🟢 +37.9%
Baseline details

Latest main 02ae12b from same runner

config metric PR latest main 7d avg Δ latest Δ 7d
bs=10 sw=10 sl=64 throughput 551 tuples/sec 579 tuples/sec 786.12 tuples/sec -4.8% -29.9%
bs=10 sw=10 sl=64 MB/s 0.336 MB/s 0.353 MB/s 0.48 MB/s -4.8% -30.0%
bs=10 sw=10 sl=64 p50 17,573 us 16,254 us 12,305 us +8.1% +42.8%
bs=10 sw=10 sl=64 p95 23,210 us 24,655 us 15,774 us -5.9% +47.1%
bs=10 sw=10 sl=64 p99 23,210 us 24,655 us 18,978 us -5.9% +22.3%
bs=100 sw=10 sl=64 throughput 1,191 tuples/sec 1,215 tuples/sec 999.71 tuples/sec -2.0% +19.1%
bs=100 sw=10 sl=64 MB/s 0.727 MB/s 0.741 MB/s 0.61 MB/s -1.9% +19.1%
bs=100 sw=10 sl=64 p50 82,464 us 77,351 us 100,616 us +6.6% -18.0%
bs=100 sw=10 sl=64 p95 111,035 us 117,876 us 107,356 us -5.8% +3.4%
bs=100 sw=10 sl=64 p99 111,035 us 117,876 us 113,255 us -5.8% -2.0%
bs=1000 sw=10 sl=64 throughput 1,422 tuples/sec 1,429 tuples/sec 1,031 tuples/sec -0.5% +37.9%
bs=1000 sw=10 sl=64 MB/s 0.868 MB/s 0.872 MB/s 0.63 MB/s -0.5% +37.9%
bs=1000 sw=10 sl=64 p50 697,398 us 700,117 us 980,328 us -0.4% -28.9%
bs=1000 sw=10 sl=64 p95 743,145 us 744,294 us 1,027,528 us -0.2% -27.7%
bs=1000 sw=10 sl=64 p99 743,145 us 744,294 us 1,054,298 us -0.2% -29.5%
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,362.79,200,128000,551,0.336,17573.36,23209.68,23209.68
1,100,10,64,20,1679.83,2000,1280000,1191,0.727,82464.20,111034.60,111034.60
2,1000,10,64,20,14066.68,20000,12800000,1422,0.868,697397.99,743144.65,743144.65

@Yicong-Huang Yicong-Huang changed the title Skip contributor template check for renovate-bot ci: skip contributor template check for renovate-bot's User account Jul 29, 2026
@Yicong-Huang
Yicong-Huang added this pull request to the merge queue Jul 29, 2026
Merged via the queue into apache:main with commit 42493c6 Jul 29, 2026
46 of 49 checks passed
@Yicong-Huang
Yicong-Huang deleted the fix/template-check-skip-renovate-bot branch July 29, 2026 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci changes related to CI fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Template-compliance check nags renovate-bot because it runs under a User account

2 participants