Skip to content

fix(ci): type routine Renovate bumps as chore, drop [security] suffix - #7072

Merged
Yicong-Huang merged 1 commit into
apache:mainfrom
Yicong-Huang:fix/renovate-chore-prefix
Jul 29, 2026
Merged

fix(ci): type routine Renovate bumps as chore, drop [security] suffix#7072
Yicong-Huang merged 1 commit into
apache:mainfrom
Yicong-Huang:fix/renovate-chore-prefix

Conversation

@Yicong-Huang

@Yicong-Huang Yicong-Huang commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

Two corrections to .github/renovate.json5:

  1. Routine bumps are now chore(...). extends: ['config:recommended'] pulls in the :semanticPrefixFixDepsChoreOthers preset, whose packageRules type runtime dependencies as fix and override our top-level semanticCommitType: 'chore'. So routine, non-security majors came through as fix(...) — e.g. chore(deps, frontend): update dependency ng-zorro-antd to v22 #7060 (ng-zorro-antd v22), chore(deps, frontend): update dependency fuse.js to v7 #7059 (fuse.js v7) — while devDependency bumps correctly stayed chore(...). A catch-all rule (matchPackageNames: ['*'] → chore) now runs last and overrides the preset.
  2. Drop the [security] title suffix. commitMessageSuffix: '' inside vulnerabilityAlerts removes Renovate's default [SECURITY] suffix; the security label already identifies those PRs.

Resulting behavior:

  • Routine bump → chore(deps, ...): ...
  • Vulnerability fix → fix(deps, ...): ... + security label (no [security] suffix)

vulnerabilityAlerts is applied as a higher-priority layer for security branches, so it keeps its fix type regardless of the catch-all.

Any related issues, documentation, discussions?

Fixes #7071. The mis-typed routine PRs that surfaced this: #7060, #7059.

How was this PR tested?

Validated with the official renovate-config-validator (npx --package renovate -- renovate-config-validator .github/renovate.json5), which reported Config validated successfully. No unit tests apply to a Renovate configuration change.

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Claude Opus 4.8)

config:recommended pulls in :semanticPrefixFixDepsChoreOthers, which
types runtime-dependency bumps as fix(...) and overrides our top-level
semanticCommitType: 'chore'. Routine, non-security majors such as
ng-zorro-antd (apache#7060) and fuse.js (apache#7059) therefore came through as
fix(...) rather than chore(...).

Append a catch-all packageRule (matchPackageNames: ['*'] -> chore) that
runs last and overrides the preset, so every routine bump is chore(...).
vulnerabilityAlerts is applied as a higher-priority layer for security
branches and keeps its fix(...) type.

Also set commitMessageSuffix: '' in vulnerabilityAlerts to drop
Renovate's default [SECURITY] title suffix; the security label already
identifies those PRs.

Fixes apache#7071

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added fix ci changes related to CI labels Jul 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • No candidates found from git blame history.

@codecov-commenter

codecov-commenter commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.27%. Comparing base (02ae12b) to head (a2a509b).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7072   +/-   ##
=========================================
  Coverage     79.27%   79.27%           
- Complexity     3787     3788    +1     
=========================================
  Files          1160     1160           
  Lines         46124    46124           
  Branches       5114     5114           
=========================================
+ Hits          36563    36565    +2     
+ Misses         7942     7941    -1     
+ Partials       1619     1618    -1     
Flag Coverage Δ
access-control-service 70.00% <ø> (ø)
agent-service 76.76% <ø> (ø)
amber 72.62% <ø> (+0.01%) ⬆️
computing-unit-managing-service 20.49% <ø> (ø)
config-service 66.66% <ø> (ø)
file-service 67.21% <ø> (ø)
frontend 83.08% <ø> (ø)
notebook-migration-service 78.94% <ø> (ø)
pyamber 96.34% <ø> (ø)
workflow-compiling-service 26.31% <ø> (ø)

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Benchmark changes need a look

🟢 2 better · 🔴 2 worse · ⚪ 11 noise (<±5%) · 0 without baseline

Compared against main 02ae12b benchmarked on this same runner, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.

Dashboard · Run

config throughput MB/s latency max Δ latest / 7d
🟢 bs=10 sw=10 sl=64 441 0.269 21,507/31,794/31,794 us 🟢 -9.9% / 🔴 +101.6%
🔴 bs=100 sw=10 sl=64 954 0.582 100,806/134,194/134,194 us 🔴 +9.9% / 🔴 +25.0%
bs=1000 sw=10 sl=64 1,115 0.681 899,278/968,140/968,140 us ⚪ within ±5% / 🟢 -8.3%
Baseline details

Latest main 02ae12b from same runner

config metric PR latest main 7d avg Δ latest Δ 7d
bs=10 sw=10 sl=64 throughput 441 tuples/sec 444 tuples/sec 786.12 tuples/sec -0.7% -43.9%
bs=10 sw=10 sl=64 MB/s 0.269 MB/s 0.271 MB/s 0.48 MB/s -0.7% -43.9%
bs=10 sw=10 sl=64 p50 21,507 us 21,329 us 12,305 us +0.8% +74.8%
bs=10 sw=10 sl=64 p95 31,794 us 35,295 us 15,774 us -9.9% +101.6%
bs=10 sw=10 sl=64 p99 31,794 us 35,295 us 18,978 us -9.9% +67.5%
bs=100 sw=10 sl=64 throughput 954 tuples/sec 975 tuples/sec 999.71 tuples/sec -2.2% -4.6%
bs=100 sw=10 sl=64 MB/s 0.582 MB/s 0.595 MB/s 0.61 MB/s -2.2% -4.6%
bs=100 sw=10 sl=64 p50 100,806 us 101,247 us 100,616 us -0.4% +0.2%
bs=100 sw=10 sl=64 p95 134,194 us 122,145 us 107,356 us +9.9% +25.0%
bs=100 sw=10 sl=64 p99 134,194 us 122,145 us 113,255 us +9.9% +18.5%
bs=1000 sw=10 sl=64 throughput 1,115 tuples/sec 1,112 tuples/sec 1,031 tuples/sec +0.3% +8.1%
bs=1000 sw=10 sl=64 MB/s 0.681 MB/s 0.679 MB/s 0.63 MB/s +0.3% +8.2%
bs=1000 sw=10 sl=64 p50 899,278 us 892,821 us 980,328 us +0.7% -8.3%
bs=1000 sw=10 sl=64 p95 968,140 us 955,256 us 1,027,528 us +1.3% -5.8%
bs=1000 sw=10 sl=64 p99 968,140 us 955,256 us 1,054,298 us +1.3% -8.2%
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,453.63,200,128000,441,0.269,21507.32,31794.21,31794.21
1,100,10,64,20,2096.14,2000,1280000,954,0.582,100806.08,134194.34,134194.34
2,1000,10,64,20,17931.10,20000,12800000,1115,0.681,899277.92,968139.99,968139.99

@Yicong-Huang
Yicong-Huang added this pull request to the merge queue Jul 29, 2026
Merged via the queue into apache:main with commit f303f05 Jul 29, 2026
44 checks passed
@Yicong-Huang
Yicong-Huang deleted the fix/renovate-chore-prefix branch July 29, 2026 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci changes related to CI fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Renovate types routine dependency bumps as fix instead of chore, and appends a [security] suffix to security PR titles

3 participants