THRIFT-6045: Limit struct read/write recursion depth in Ruby library#3550
Draft
Jens-G wants to merge 1 commit into
Draft
THRIFT-6045: Limit struct read/write recursion depth in Ruby library#3550Jens-G wants to merge 1 commit into
Jens-G wants to merge 1 commit into
Conversation
Client: rb Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
kpumuk
requested changes
May 28, 2026
Member
kpumuk
left a comment
kpumuk
left a comment
There was a problem hiding this comment.
This PR is insufficient:
- It only covers pure Ruby implementation, and not the native extension
- It does not cover Union
- There are no tests
I am currently working on https://issues.apache.org/jira/browse/THRIFT-5938, with recursion depth enforcement being a part of the problem. I can extract my change to merge it ahead of the configuration class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
increment_recursion_depth/decrement_recursion_depthmethods toBaseProtocolProtocolException::DEPTH_LIMITwhen exceededStructmodule'sread/writemethods wrap the body withbegin/ensureto guarantee the counter is always restoredTest plan
ruby -Ilib test/unit/...🤖 Generated with Claude Code
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com