THRIFT-6051: Limit struct read/write recursion depth in OCaml library#3556
Draft
Jens-G wants to merge 1 commit into
Draft
THRIFT-6051: Limit struct read/write recursion depth in OCaml library#3556Jens-G wants to merge 1 commit into
Jens-G wants to merge 1 commit into
Conversation
Client: ocaml - Add recursion_depth_ field and increment/decrement_recursion_depth methods to Protocol.t in Thrift.ml - Move type exn_type and exception E before class virtual t to fix a pre-existing forward-reference bug (Protocol.INVALID_DATA in skip) - Generator wraps struct read/write with Fun.protect to ensure decrement_recursion_depth always runs even on exception - Limit is 64 levels; raises Protocol.E(DEPTH_LIMIT,...) on excess Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
recursion_depth_field andincrement_recursion_depth/decrement_recursion_depthmethods toProtocol.tinThrift.mlexn_typeand exceptionEbeforeclass virtual tFun.protectto guarantee decrement even on exceptionProtocol.E(DEPTH_LIMIT, …)on excessTest plan
dune test🤖 Generated with Claude Code
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com