THRIFT-6052: Limit struct read/write recursion depth in Smalltalk library#3557
Draft
Jens-G wants to merge 1 commit into
Draft
THRIFT-6052: Limit struct read/write recursion depth in Smalltalk library#3557Jens-G wants to merge 1 commit into
Jens-G wants to merge 1 commit into
Conversation
Client: st - Add recursionDepth instance variable to TProtocol - Add incrementRecursionDepth (limit 64) and decrementRecursionDepth methods; raises TProtocolError on excess - Add depthLimit class method to TProtocolError (returns 6) - Generator wraps struct read/write blocks with ensure: to guarantee decrementRecursionDepth always runs even when an exception is raised - Also fixes a pre-existing bug: struct_reader used oprot instead of iprot for readStructEnd Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
recursionDepthinstance variable toTProtocolwithincrementRecursionDepth/decrementRecursionDepthmethodsTProtocolError depthLimiton excessstruct_readerwas passingoprottoreadStructEndinstead ofiprotensure:to guarantee decrementTest plan
TProtocolTestinlib/st/🤖 Generated with Claude Code
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com