THRIFT-6053: Limit struct read/write recursion depth in D library#3558
Draft
Jens-G wants to merge 1 commit into
Draft
THRIFT-6053: Limit struct read/write recursion depth in D library#3558Jens-G wants to merge 1 commit into
Jens-G wants to merge 1 commit into
Conversation
Client: d - Add a thread-local recursion depth counter in thrift.codegen.base - readStruct and writeStruct increment the counter on entry and decrement it via scope(exit) on normal or exceptional exit - Limit is 64 levels; raises TProtocolException.DEPTH_LIMIT on excess - Add unittest verifying the depth limit and rollback behaviour Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
thrift.codegen.basereadStructandwriteStructincrement on entry and decrement viascope(exit)on normal or exceptional returnTProtocolException.DEPTH_LIMITon excessunittestverifying depth limit and rollback behaviourTest plan
unittestblock inlib/d/verifies depth limit and counter restoration🤖 Generated with Claude Code
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com