THRIFT-6055: Limit struct read/write recursion depth in JavaME library#3560
Draft
Jens-G wants to merge 1 commit into
Draft
THRIFT-6055: Limit struct read/write recursion depth in JavaME library#3560Jens-G wants to merge 1 commit into
Jens-G wants to merge 1 commit into
Conversation
Client: javame Add DEPTH_LIMIT constant (6) to TProtocolException, plus incrementRecursionDepth()/decrementRecursionDepth() methods to TProtocol with a fixed limit of 64. Update the JavaME generator to call these around struct read and write bodies using try/finally so the counter is always restored even when an exception propagates. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DEPTH_LIMIT = 6constant toTProtocolExceptionincrementRecursionDepth()/decrementRecursionDepth()toTProtocolwith a hard limit of 64try/finallyto guarantee the counter is always restoredTest plan
🤖 Generated with Claude Code
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com