THRIFT-6056: Limit struct read/write recursion depth in Dart library#3561
Draft
Jens-G wants to merge 1 commit into
Draft
THRIFT-6056: Limit struct read/write recursion depth in Dart library#3561Jens-G wants to merge 1 commit into
Jens-G wants to merge 1 commit into
Conversation
Client: dart Add _recursionDepth counter and incrementRecursionDepth() / decrementRecursionDepth() methods to TProtocol, with a hard limit of 64. Update the Dart generator to call these methods around the struct read/write body using try/finally so the counter is always restored. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_recursionDepthcounter,incrementRecursionDepth()/decrementRecursionDepth()toTProtocolTProtocolErrorwithTProtocolErrorType.DEPTH_LIMITon excesstry/finallyto guarantee counter restorationTest plan
lib/dart/test/protocol/t_protocol_recursion_depth_test.dart— covers allow/reject/restoredart testinlib/dartpasses🤖 Generated with Claude Code
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com