THRIFT-6108: implemented exception documentation generation#3666
Open
SLAVONchick wants to merge 1 commit into
Open
THRIFT-6108: implemented exception documentation generation#3666SLAVONchick wants to merge 1 commit into
SLAVONchick wants to merge 1 commit into
Conversation
SLAVONchick
requested review from
Jens-G,
emmenlau,
fishy,
jimexist and
mhlakhani
as code owners
July 23, 2026 12:21
Jens-G
requested changes
Jul 23, 2026
| t_field* e = *e_iter; | ||
| std::string namespace_str = e->get_type()->get_program()->get_namespace(lang); | ||
|
|
||
| if (static_cast<std::string>(lang).compare("cpp") == 0) { |
Member
There was a problem hiding this comment.
No, really, don't. We have OOP these days, like in "t_oop_generator", so we can use virtual methods to do such stuff.
PS: Pun intended - SCNR 🤣
Author
There was a problem hiding this comment.
Totally agree, my bad. Fixed.
Member
|
I like the idea. Would be glad to see this move forward. |
Jens-G
reviewed
Jul 23, 2026
| #ifndef T_OOP_GENERATOR_H | ||
| #define T_OOP_GENERATOR_H | ||
|
|
||
| #include <boost/algorithm/string/replace.hpp> |
Member
There was a problem hiding this comment.
IIRC we don't use boost in the compiler. Can this be replaced by sth else?
Author
There was a problem hiding this comment.
Found identical implementations in several generators and left only one in base t_oop_generator.
mergeable
Bot
added
c_glib
dart
Client: cpp,haxe,java,netstd,py
Author
Hi! Thank you for the review! I'm really looking forward to finish this work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client: cpp,haxe,java,netstd,py
In this PR I've implemented the documentation generation of the exceptions thrown in the service methods.
I skipped the clients where there is no documentation is generated at all, so it only touched cpp,haxe,java,netstd,py.
[skip ci]anywhere in the commit message to free up build resources. - Does involve code.