Avoid Python test server port-allocation races#3667
Open
kpumuk wants to merge 1 commit into
Open
Conversation
Client: py Co-Authored-By: OpenAI Codex (GPT-5.6) <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RunClientServer.pyselected an unused port by binding a temporary socket, closing it, and then launchingTestServer.pyon the same port. Another process could claim the port during that gap, causing intermittent macOS failures withOSError: [Errno 48] Address already in use.Let each test server bind port
0so the kernel allocates and owns the port, then report the bound port to the parent before the client starts. The same reporting path covers regular, SSL, and HTTP test servers; ephemeral HTTP tests bind to loopback and avoid hostname lookup during startup.Representative failures include macOS 26 with Python 3.11, macOS 14 with Python 3.13, Intel macOS 15 with Python 3.10, macOS 26 with Python 3.10, and macOS 15 with Python 3.13. Each failed in the Python check while binding a test-server socket with
OSError: [Errno 48] Address already in use.[skip ci]anywhere in the commit message to free up build resources. — Not applicable; this changes Python test-harness code.