-
Notifications
You must be signed in to change notification settings - Fork 860
Implement Provider Defined Types (PDT) #3433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+7,117
−611
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
f8cc2f6
Implement Provider Defined Types (PDT) for TinkerPop 4
Cole-Greer 16faf02
cleanup
Cole-Greer 0117cdd
Enable annotation-based PDT round-trip hydration in Java and .NET
Cole-Greer 862a5cc
Address PDT PR review: validation, docs, precedence tests, cleanup
Cole-Greer f4c5b43
Address PDT PR review: SPI auto-wiring, API renames, test relocation
Cole-Greer 76b9629
Integrate PDT JPMS note into Java round-trip docs instead of standalo…
Cole-Greer 7498dc4
Guard .NET annotation-based PDT hydration against failures and nested…
Cole-Greer b74f690
Hydrate registered PDTs nested inside unregistered outer types
Cole-Greer 51202ac
Fix full-build regressions: restore gremlin-server test-jar and finis…
Cole-Greer 57c959c
Fix rebase conflict resolutions for Go and .NET PDT wiring
Cole-Greer f8bf0a9
Fix JS rebase resolution: keep RemoteConnection.options public for PD…
Cole-Greer ccd3d7e
Finish properties->fields rename for PDT across translator, docs, and…
Cole-Greer 89501d2
Rename remaining PDT props/properties identifiers to fields
Cole-Greer 5140d06
Align PDT field-map naming in .NET GremlinLang dehydration
Cole-Greer 959f28e
Complete PDT props->fields rename in Go and Python production + tests
Cole-Greer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add contraints and error behaviour section of some sort? I think something for property map keys must be
Stringand the typenamemust be non-empty.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've folded details about the String keys and non-empty field names into the basic usage section.