[UNOMI-924] Make healthcheck concurrent#746
Merged
Conversation
…d add a 1s cache for performance or DoS issues.
jsinovassin
approved these changes
Dec 29, 2025
jsinovassin
approved these changes
Dec 31, 2025
jsinovassin
approved these changes
Dec 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
HealthCheckServiceto improve thread safety, caching, and concurrency, as well as to simplify the health check execution logic. The main changes include introducing a cache for health check results, switching to a cached thread pool, and removing unnecessary stream usage.Thread safety and caching improvements:
healthCache) for health check results, a timestamp (cacheTimestamp), and synchronization logic to prevent concurrent refreshes. This ensures results are not recomputed too frequently and improves performance under load. [1] [2]cacheLockobject andbusyflag to coordinate cache refreshes and avoid race conditions. [1] [2]Concurrency and execution changes:
Futureand timeouts when executing health check providers; now callsprovider.execute()directly and handles exceptions by marking the provider as timed out.Code simplification and cleanup:
toList()call. [1] [2]