Conversation
- processors in the root process group. The import of templates with processors
in the root process group fails because such a process group is internally know
as 'NiFi Flow' but cannot be reached by that name through the API. This change ff
ixes this issue by setting, depending on the pgName, the correct path in _changee
ProcessGroupState().
- literal json blocks are not correctly accepted with toPrettyString(). I replacc
ed those calls with toString(). Look for the '|-' string in sample_template.yml
for examples of where this error occurs.
- the controller service name regex lookup fails when a function name is used inn
the name. For instance a name like ${event_type:toLower():equals('ad')} cannot
be looked up and will result in an error. I changed the regex to accept any namee
, except ones that hold :, ( or ) characters.
Owner
|
Hey @jvanbemmelen thanks for this PR! I will take a look at these in the next few days. Your groovy-fu is not bad at all, keep them coming :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to import this template results in a number of errors related to:
This is my first attempt at using Groovy, and my first ever pull request, so please let me know if there's anything missing/wrong :-).