Skip to content

Changes to run sample app in user mode#56

Merged
afawcett merged 2 commits intomasterfrom
defaulting-to-usermode
Apr 13, 2026
Merged

Changes to run sample app in user mode#56
afawcett merged 2 commits intomasterfrom
defaulting-to-usermode

Conversation

@afawcett
Copy link
Copy Markdown
Contributor

@afawcett afawcett commented Mar 18, 2026

This change is Reviewable

Copy link
Copy Markdown
Contributor

@daveespo daveespo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the comment about the way the constructor overload works, I'm good with this PR so once that's resolved, I can approve this

@daveespo made 2 comments.
Reviewable status: 0 of 19 files reviewed, 1 unresolved discussion (waiting on afawcett, ImJohnMDaniel, and john-storey-devops).


sfdx-source/apex-common-samplecode/main/classes/selectors/AccountsSelector.cls line 40 at r1 (raw file):

	public AccountsSelector()
	{
		super(false);

I think we should use the overloaded constructor. It's more concise:

super(false,fflib_SObjectSelector.DataAccess.USER_MODE);

(applies throughout this PR)

@afawcett
Copy link
Copy Markdown
Contributor Author

@daveespo feedback addressed

Copy link
Copy Markdown
Contributor

@daveespo daveespo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daveespo reviewed 19 files and all commit messages, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ImJohnMDaniel and john-storey-devops).

@afawcett afawcett merged commit 5a37f12 into master Apr 13, 2026
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants