Changes to run sample app in user mode#56
Conversation
daveespo
left a comment
There was a problem hiding this comment.
Aside from the comment about the way the constructor overload works, I'm good with this PR so once that's resolved, I can approve this
@daveespo made 2 comments.
Reviewable status: 0 of 19 files reviewed, 1 unresolved discussion (waiting on afawcett, ImJohnMDaniel, and john-storey-devops).
sfdx-source/apex-common-samplecode/main/classes/selectors/AccountsSelector.cls line 40 at r1 (raw file):
public AccountsSelector() { super(false);
I think we should use the overloaded constructor. It's more concise:
super(false,fflib_SObjectSelector.DataAccess.USER_MODE);
(applies throughout this PR)
|
@daveespo feedback addressed |
daveespo
left a comment
There was a problem hiding this comment.
@daveespo reviewed 19 files and all commit messages, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ImJohnMDaniel and john-storey-devops).
This change is