Skip to content

Fix concurrency issue by copying map of Fields#110

Open
bertzzie wants to merge 1 commit intoapex:masterfrom
bertzzie:master
Open

Fix concurrency issue by copying map of Fields#110
bertzzie wants to merge 1 commit intoapex:masterfrom
bertzzie:master

Conversation

@bertzzie
Copy link

Hello,

Opening this PR to fix issue #74 if you are open to contribution. Basically this PR is taking suggestion from the issue:

Perhaps func (f Fields) Fields() Fields should make a shallow copy of the underlying map instead of just returning the Fields struct?

Alongside with unit test to demonstrate the issue and that it's fixed.

Let me know if there's something to improve. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant