allow users to create Levels directly from integers#94
Open
paulangton wants to merge 2 commits intoapex:masterfrom
Open
allow users to create Levels directly from integers#94paulangton wants to merge 2 commits intoapex:masterfrom
paulangton wants to merge 2 commits intoapex:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If users want to create a
log.Leveldirectly from an integer they need to wait forlog.SetLevelto fail or write their own checks for whether a log level integer is valid. Instead we could provideFromIntto do this work upstream where it has access to package-privatelevelStringsandlevelNames