fix(laravel): persist dirty embedded belongsTo relations#8246
Merged
soyuka merged 1 commit intoJun 5, 2026
Conversation
Previously, PersistProcessor only saved the related model when it did not yet exist. For PATCH requests using deep_object_to_populate, an embedded relation already existed but its attributes had been modified; those changes were silently dropped. Save when the relation is new or dirty so denormalized changes propagate. Fixes api-platform#6882
soyuka
force-pushed
the
fix/laravel-embedded-relations-6882
branch
from
1fadf3f to
09543f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PATCH requests targeting an embedded BelongsTo/MorphTo relation silently dropped attribute changes: the persistor only called
save()on new relations, never on dirty ones. Save onnew || dirtyso denormalized modifications propagate.Reproduction
PATCH a
CartItemwith a nestedshoppingCartpayload containing an updateduserIdentifier— the parent cart was not updated.Test plan
Fixes #6882