fix(openapi): ship oauth2-redirect.js with swagger-ui assets#8261
Open
soyuka wants to merge 1 commit into
Open
fix(openapi): ship oauth2-redirect.js with swagger-ui assets#8261soyuka wants to merge 1 commit into
soyuka wants to merge 1 commit into
Conversation
The Swagger UI OAuth2 authorization code flow redirects to oauth2-redirect.html which references oauth2-redirect.js. The latter was missing from the published bundle/laravel asset folders because update-js.sh did not copy it, breaking the OAuth2 login flow with a 404 on the JS file. Ship oauth2-redirect.js alongside oauth2-redirect.html in both Symfony bundle and Laravel public asset folders, and update update-js.sh so future dependency bumps keep the pair in sync. Fixes api-platform#8243
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
oauth2-redirect.jsalongsideoauth2-redirect.htmlin bothsrc/Symfony/Bundle/Resources/public/swagger-ui/andsrc/Laravel/public/swagger-ui/.update-js.shso future dependency bumps keep the pair in sync.Test plan
tests/Symfony/Bundle/SwaggerUi/OAuth2RedirectAssetsTest.phpasserts both files exist next tooauth2-redirect.html.Fixes #8243